Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new dependencies to zip files: share, shippers and storage #692

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Apr 18, 2024

What does this PR do?

When building the zip file of the dependencies, we also add:

  • share
  • storage
  • shippers

This is needed because the handlers are importing these. Otherwise the ESF lambda function will fail.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

How to test this PR locally

You can run the step commands locally, and it should work fine.

Issues

Relates to #683.

Signed-off-by: constanca <[email protected]>
@constanca-m constanca-m merged commit 30c41f4 into elastic:main Apr 22, 2024
4 checks passed
@constanca-m constanca-m deleted the fix-upload-dependencies branch April 22, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants