-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove call to EC2:DescribeRegions API #811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
reviewed
Sep 25, 2024
- Lookup the lambda region using environment variables. - Save the `parse_arn` for another day.
constanca-m
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the call to the EC2:DescribeRegions API.
Why is it important?
We aim to increase performance and avoid throttling.
As of today, the Lambda runtime can only trigger the function from a (CloudWatch) log group in the same region as the function.
Since the log group and function region are the same, we can use the lambda function region to look up 1 the input in the configuration and avoid matching with all the existing regions.
Checklist
CHANGELOG.md
Footnotes
We need a region to lookup the input in the config file because the log event from cloudwatch does not contain the region. ↩