Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove call to EC2:DescribeRegions API #811

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Sep 24, 2024

What does this PR do?

Remove the call to the EC2:DescribeRegions API.

Why is it important?

We aim to increase performance and avoid throttling.

As of today, the Lambda runtime can only trigger the function from a (CloudWatch) log group in the same region as the function.

Since the log group and function region are the same, we can use the lambda function region to look up 1 the input in the configuration and avoid matching with all the existing regions.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Footnotes

  1. We need a region to lookup the input in the config file because the log event from cloudwatch does not contain the region.

@zmoog zmoog self-assigned this Sep 24, 2024
@zmoog zmoog added bug Something isn't working Team:obs-ds-hosted-services labels Sep 24, 2024
@zmoog zmoog changed the title Remove describe regions Remove call to EC2:DescribeRegions API Sep 24, 2024
@zmoog zmoog marked this pull request as ready for review September 24, 2024 23:24
@zmoog zmoog merged commit e6f6392 into main Sep 25, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/remove-describe-regions branch September 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:obs-ds-hosted-services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants