Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix test coverage reporting #819

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 3, 2024

What does this PR do?

Add pull-requests permissions to the coverage reporting in the test-reporter can do its job.

Why is it important?

Fixes the required permissions otherwise the reporting will fail, see https://github.com/elastic/elastic-serverless-forwarder/actions/runs/11146807195/job/30979622250

image

That's something we have discovered through our Observability CICD with OTEL for GH actions that alerted us that something was not right

image

@v1v v1v requested a review from reakaleek October 3, 2024 08:39
@v1v v1v self-assigned this Oct 3, 2024
@v1v v1v merged commit d39cad4 into elastic:main Oct 3, 2024
4 checks passed
@v1v v1v deleted the fix/integration-test-error branch October 3, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants