Update to jackson 2.8.1 #18939
Merged
Update to jackson 2.8.1 #18939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JsonStreamContext context = base.getOutputContext(); | ||
| if (context instanceof JsonWriteContext) { | ||
| ((JsonWriteContext) context).writeValue(); | ||
| } |
There was a problem hiding this comment.
should we put an assertions that it actually is a JsonWriteContext?
|
2.8.0 has been released: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8 |
tlrx
force-pushed
the
update-to-jackson-2.8.0
branch
from
d07cb8f to
d7fba30
Compare
|
2.8.1 has been released: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.8.1 |
|
@s1monw Do you want to have another look? |
| assertEquals("\"responses\"[{\"error\":{\"root_cause\":[{\"type\":\"illegal_state_exception\",\"reason\":\"foobar\"}],\"type\":\"illegal_state_exception\",\"reason\":\"foobar\"},\"status\":500},{\"error\":{\"root_cause\":[{\"type\":\"illegal_state_exception\",\"reason\":\"baaaaaazzzz\"}],\"type\":\"illegal_state_exception\",\"reason\":\"baaaaaazzzz\"},\"status\":500}]", | ||
| builder.endObject(); | ||
|
|
||
| assertEquals("{\n" + |
There was a problem hiding this comment.
pretty printing is difficult, not sure if it works on windows with trailing whiltespaces / new lines etc?
|
left some comments @tlrx thanks for doing this |
|
@s1monw Thanks for your review! I removed all pretty printings. |
|
Rally benchmarks shows no performance regression. I'd like to merge it soon - can I go @s1monw ? |
|
LGTM |
This commit updates Jackson to the 2.8.1 version, which is more strict when it comes to build objects. It also adds the snakeyaml dependency that was previously shaded in jackson libs. It also closes elastic#18076
tlrx
force-pushed
the
update-to-jackson-2.8.0
branch
from
787ed6a to
841d5a2
Compare
|
Thanks @s1monw ! |
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this pull request
Aug 9, 2016
See elastic#19773 (comment) Was introduced with elastic#18939
|
Great need this one too +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jackson 2.8.1 has been released. This PR updates the version to the latest version of Jackson which fix #18076 and is also more strict when it build objects.