Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed forward of non accepted parameters to transport constructor #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabypascha
Copy link

The transport class does not accept the parameters in its constructor and it is passed in the node_configs instead.

The transport class constructor does not accept the following parameters :

  • connections_per_node
  • http_compress
  • verify_certs

The passing of these parameters causes TypeErrors as the constructor receives unexpected keyword arguments.

These parameters are now passed through the node_configs parameter instead.

…or. It is passed in the node_configs instead.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
86739e4

Please, read and sign the above mentioned agreement if you want to contribute to this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants