[INFRA] Build and use optimized Docker image in Buildkite jobs #7372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding Dockerfile install deps using Alpine Node. * Switching to docker-compose file to maximize caching.
* Ignoring Cypress a11y routine until test fixes are added. * Changed to docker-login --password-stdin. * Updated Docker image URL in test shell script.
| @@ -3,4 +3,4 @@ | |||
| set -euo pipefail | |||
There was a problem hiding this comment.
It doesn't hurt to have this file, but FYI you shouldn't need it either... The process should exit right after this, so all of the env vars will be gone anyway
💔 Build Failed
Failed CI StepsHistory
cc @1Copenut |
|
Preview staging links for this PR:
|
3 tasks
|
Closing this for now, we will open up a new PR with a second attempt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR looks to accomplish two goals:
I've requested Ops to review this PR along with the EUI team. There's a couple new wrinkles I'd like to have them review before merging.
First QA pass (draft PR)
QA will all be done in Buildkite. Definition of done is as follows:
Second QA pass (final review)
This second pass of QA will update the registry and Docker image. We will do the same review as the staging pass and then merge when finished.