Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Increase form control borders to 3:1 WCAG AA contrast ratios #7930

Closed
wants to merge 8 commits into from

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Jul 29, 2024

Summary

closes #7509

Before

Light mode Dark mode
1.21:1 contrast ratio 1.35:1 contrast ratio

After

Light mode Dark mode
3:1 contrast ratio 3.03:1 contrast ratio

Note: Sass and Emotion outputs transparent colors in rgba() vs hex codes with alpha. You can convert the rgba colors to hex using https://rgbacolorpicker.com/rgba-to-hex before checking the contrast in https://webaim.org/resources/contrastchecker/

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked for accessibility including `keyboard-only and screenreader modes
    • Checked in Chrome, Safari, Edge, and Firefox
      - [ ] Checked in mobile
  • Docs site QA - N/A
  • Code quality checklist
    - [ ] Added or updated jest and cypress tests
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

cee-chen added 2 commits July 29, 2024 16:22
- light mode is slightly different, presumably due to differences in shading/tinting logic
@cee-chen cee-chen force-pushed the input-borders-wcag-aa branch from 393304b to 9b736c0 Compare July 30, 2024 22:43
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@cee-chen
Copy link
Contributor Author

Going to go ahead and close this - this isn't something we plan on implementing in the default EUI theme in the near future, although it can certainly be reused for a future high contrast theme.

@cee-chen cee-chen closed this Aug 13, 2024
@cee-chen cee-chen deleted the input-borders-wcag-aa branch August 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input borders should meet the WCAG AA contrast ratio requirements
2 participants