Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap few colors for EuiLoadingSpinner and EuiLoadingChart #8274

Closed

Conversation

ek-so
Copy link
Contributor

@ek-so ek-so commented Jan 15, 2025

Summary

This small PR:

  • Changes grey shades used for the EuiLoadingChart in mono version in dark mode:
    CleanShot 2025-01-15 at 09 22 38@2x
  • Maps EuiLoadingSpinner to unilize Borealis tokens instead of old Amsterdam tokens.
    CleanShot 2025-01-15 at 09 23 07@2x

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in Chrome, Safari, Edge, and Firefox

@ek-so ek-so marked this pull request as ready for review January 15, 2025 08:27
@ek-so ek-so requested a review from a team as a code owner January 15, 2025 08:27
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 15, 2025

💔 Build Failed

Failed CI Steps

History

cc @mgadewoll

@ek-so ek-so changed the base branch from main to eui-theme/borealis January 15, 2025 08:54
@mgadewoll mgadewoll self-assigned this Jan 15, 2025
@ek-so
Copy link
Contributor Author

ek-so commented Jan 15, 2025

Will create new PRS splitted as agreed.

@ek-so ek-so closed this Jan 15, 2025
@kibanamachine
Copy link

Preview staging links for this PR:

@mgadewoll mgadewoll removed their assignment Jan 15, 2025
@ek-so ek-so deleted the ekso-loading-indicators branch January 17, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants