Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some documentation #128
Add some documentation #128
Changes from all commits
f4fd0ea
9e2124f
eac79d5
da08f27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this -- appreciate the first principals level-set here 🙂. The output (data generated) just needs to meet the minimum interface contract defined by the input query, and can and should vary indiscriminately outside of that.
As a further abstraction (which could be an input to Geneve), have you had any thoughts around some sort of input definition spec or anything? This is probably most applicable to the "click through" example mentioned above, but could be useful when needing to generate multiple documents and managing the references and chained dependencies between each (e.g. capturing parent/child relationships, generating sub-documents that are in the correct subnet, etc). Supporting sequences in EQL is a sorta similar situation, albeit still defined and verifiable by the query spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh, reading further looks like the
Data Model
defined below pretty much handles this. 👍 Would be nice to package these up ala Rally Tracks so it's easy to run pre-defined configurations.