Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent status docs for unhealthy status #1288

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Sep 4, 2024

This corrects the meaning of Unhealthy for Elastic Agent status, as documented in View agent status overview.

Closes: #1284


Screenshot 2024-09-04 at 2 21 32 PM

@kilfoyle kilfoyle requested a review from a team as a code owner September 4, 2024 18:25
Copy link

github-actions bot commented Sep 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new description looks great, but I think we also need to update the diagram to match:

image

@nimarezainia
Copy link
Contributor

The new description looks great, but I think we also need to update the diagram to match:

image

yeah you are right, I'll redo this. It's a left over from before we had health reporting.

@kilfoyle
Copy link
Contributor Author

kilfoyle commented Sep 5, 2024

@kpollich I've added in the nice, new graphic:


Screenshot 2024-09-05 at 11 25 14 AM

@kilfoyle kilfoyle requested a review from kpollich September 5, 2024 15:28
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for taking care of this, and thanks @nimarezainia for helping with the diagram ❤️

Copy link

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kilfoyle kilfoyle merged commit b7c217c into elastic:main Sep 6, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Sep 6, 2024
* Fix agent status docs for unhealthy status

* Update graphic

(cherry picked from commit b7c217c)
kilfoyle added a commit that referenced this pull request Sep 6, 2024
* Fix agent status docs for unhealthy status

* Update graphic

(cherry picked from commit b7c217c)

Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: Fix agent status docs for unhealthy status
4 participants