Move section about Logstash to bottom of Kafka output page #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
lucabelluccini
approved these changes
Nov 5, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit b05a3ab)
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit b05a3ab)
This was referenced Nov 5, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
(cherry picked from commit b05a3ab)
kilfoyle
added a commit
that referenced
this pull request
Nov 5, 2024
…1436) (cherry picked from commit b05a3ab) Co-authored-by: David Kilfoyle <[email protected]>
kilfoyle
added a commit
that referenced
this pull request
Nov 5, 2024
…1435) (cherry picked from commit b05a3ab) Co-authored-by: David Kilfoyle <[email protected]>
kilfoyle
added a commit
that referenced
this pull request
Nov 5, 2024
…1434) (cherry picked from commit b05a3ab) Co-authored-by: David Kilfoyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the top of the Kafka output settings page is a section warning users about potential problems when they use use Logstash to modify the Kafka output on its way to Elasticsearch. It's not ideal for all users to start their Kafka output journey with that section.
I think it'd be better to have that section at the bottom of the Kafka output settings page, and to make sure people find the section we can add a warning at the top of the page, like this:
The guidance for Logstash appears just as before, but at the bottom of the page:
@lucabelluccini, @nimarezainia Any thoughts or concerns?