-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cyberarkpas] Collect monitoring data #11478
[cyberarkpas] Collect monitoring data #11478
Conversation
@chrisberkhout I believe |
The Regarding |
…ic-json-v1.0.xsl.
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
audit |
2739.73 | 1319.26 | -1420.47 (-51.85%) | 💔 |
To see the full report comment with /test benchmark fullreport
packages/cyberarkpas/data_stream/audit/elasticsearch/ingest_pipeline/audit.yml
Outdated
Show resolved
Hide resolved
packages/cyberarkpas/data_stream/audit/elasticsearch/ingest_pipeline/audit.yml
Show resolved
Hide resolved
packages/cyberarkpas/data_stream/monitor/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/cyberarkpas/data_stream/monitor/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits only, then LGTM
packages/cyberarkpas/data_stream/monitor/_dev/test/pipeline/test-common-config.yml
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
History
|
Quality Gate passedIssues Measures |
Package cyberarkpas - 2.24.0 containing this change is available at https://epr.elastic.co/search?package=cyberarkpas |
Proposed commit message
Author's Checklist
elastic-json-v1.0.xsl
will generate syslog data as expected,or adjust it to do so (the prefix before the JSON data may need to be built manually for monitor data). ➙ It will run successfully and generate JSON without a syslog prefix.Discussion
Elastic's stylesheet
elastic-json-v1.0.xsl
will translate audit records into a syslog prefix and a JSON suffix. For monitor records it will run successfully and generate the JSON with no prefix. That is what themonitor
data stream expects.Expand for a procedure to verify how
elastic-json-v1.0.xsl
processes monitor records.Take the
elastic-json-v1.0.xsl
file, edit it to use a non-local source for theRFC5424Changes.xsl
file:Open Free Online XSLT Test Tool and paste the XSL file into the middle box.
In the top box, put the following monitor record, press "Run Transformation" and inspect the generated JSON.
Try the following audit record to compare, and notice that it does generate a prefix.
The dashboard suggested in #11320 comes from jcreameriii/PAS-APM-Dashboard-Package-for-Splunk and does custom data generation for the service status row at the top. I have built a similar dashboard, but using only the monitoring data provided by CyberArk PAS.
Checklist
changelog.yml
file.How to test this PR locally
The
monitor
data stream has pipeline tests.It's not currently possible to system test
monitor
because its manifest doesn't have a policy template. New test assertions will be possible when elastic/elastic-package#2109 is implemented.The system test for
audit
will ingest monitoring data and route it tologs-cyberarkpas.monitor-*
. Running theaudit
system test with--defer-cleanup 10m
allows manual inspection of this.Related issues
Screenshots
The new dashboard: