Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Allow to specify an upgrade window for rolling upgrade #131964

Merged
merged 2 commits into from
May 11, 2022
Merged

[Fleet] Allow to specify an upgrade window for rolling upgrade #131964

merged 2 commits into from
May 11, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 10, 2022 •
edited
Loading

Summary

Related to #130259

Update the agent upgrade API to allow to specify an upgrade duration in seconds to progressively rollout upgrades

The bulk upgrade now support a new key rollout_duration_seconds

Example:

POST /api/fleet/agents/bulk_upgrade
{
version: 8.2.0,
agents: ['agent1', 'agent2'],
rollout_duration_seconds: 6000,
}

Tests

This is tested with an api integration tests that check we generate the correct .fleet-actions document.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 10, 2022
@nchaulet nchaulet self-assigned this May 10, 2022
@nchaulet nchaulet force-pushed the feature-upgrade-window branch from 6b88b3a to ab0ea8d Compare May 11, 2022 12:52
@nchaulet nchaulet marked this pull request as ready for review May 11, 2022 12:54
@nchaulet nchaulet requested a review from a team as a code owner May 11, 2022 12:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet mentioned this pull request May 11, 2022
Closed
30 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1266 1269 +3
Unknown metric groups

API count

id before after diff
fleet 1388 1391 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

kpollich
kpollich approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very easy to follow, nice work!

@nchaulet nchaulet merged commit 3f6df1a into elastic:main May 11, 2022
@nchaulet nchaulet deleted the feature-upgrade-window branch May 11, 2022 18:31
academo pushed a commit to academo/kibana that referenced this pull request May 12, 2022
@nchaulet
[Fleet] Allow to specify an upgrade window for rolling upgrade (elast…
358825e 
…ic#131964)
@criamico criamico mentioned this pull request May 18, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nchaulet @elasticmachine @kibana-ci @kpollich