-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] fixing dropping select all #135124
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on the tests, thank you for those!
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* fixing dropping select all * added unit test for agent list selection Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit eb4529e)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
* fixing dropping select all * added unit test for agent list selection Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit eb4529e) Co-authored-by: Julia Bardi <[email protected]>
Summary
Fixes #133523
Added logic so that query selection (select all) is not dropped on Agent list when data changes.
See detailed reasoning here:
#133523 (comment)
Didn't modify manual scenario, I think it's not right to keep all 20 agents selected when the underlying data changes, as it might result in taking action on agents that were not intended.
To verify:
After manual unselect (12 agents selected as some of the dropped automatically from view on refresh)
Checklist