Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] fixing dropping select all #135124

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Jun 24, 2022

Summary

Fixes #133523

Added logic so that query selection (select all) is not dropped on Agent list when data changes.

See detailed reasoning here:
#133523 (comment)

Didn't modify manual scenario, I think it's not right to keep all 20 agents selected when the underlying data changes, as it might result in taking action on agents that were not intended.

To verify:

  • enroll a few agents with horde (more than 20 to have multiple pages)
  • select all agents in list
  • wait until refresh happens in the background
  • expect that the select all (query) state is not lost, and actions can still be taken on all agents
  • when unselecting one agent manually, the state goes back to manual selection (e.g. 19 selected instead of 20)

image

After manual unselect (12 agents selected as some of the dropped automatically from view on refresh)
image

Checklist

@juliaElastic juliaElastic requested a review from a team as a code owner June 24, 2022 11:54
@juliaElastic juliaElastic self-assigned this Jun 24, 2022
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on the tests, thank you for those!

@juliaElastic
Copy link
Contributor Author

@elasticmachine merge upstream

@juliaElastic juliaElastic added v8.3.1 v7.17.6 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 27, 2022
@juliaElastic juliaElastic enabled auto-merge (squash) June 27, 2022 06:59
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / management field formatter field format editors URL format edit formats , and check available formats types
  • [job] [logs] FTR Configs #1 / management field formatter field format editors URL format edit formats "after each" hook for ", and check available formats types"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 833.5KB 833.6KB +79.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit eb4529e into elastic:main Jun 27, 2022
kibanamachine pushed a commit that referenced this pull request Jun 27, 2022
* fixing dropping select all

* added unit test for agent list selection

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit eb4529e)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.3
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- limit agent list total count to 10k (#135026)

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 135124

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 27, 2022
* fixing dropping select all

* added unit test for agent list selection

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit eb4529e)

Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.3.1 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agents selection resets in Fleet UI in some cases
5 participants