Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Agent activity #140428

Closed
wants to merge 51 commits into from
Closed

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Sep 9, 2022

Summary

Resolves #140267

on top of #138870

WIP

image

image

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@juliaElastic juliaElastic self-assigned this Sep 9, 2022

if (complete) {
// querying the last action result for this action in case all agents acked, to report completion time
const { aggregations } = await esClient.search({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find a better way to determine the completion time of an action, other than to query the last timestamp of action results for this action. Maybe we could have a field on the action document itself to record the completion time when the last agent acked the action.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 12, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 719 721 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 873 876 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 865.8KB 872.4KB +6.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 105.7KB 106.1KB +418.0B
Unknown metric groups

API count

id before after diff
fleet 970 973 +3

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 7 6 -1
total -2

ESLint disabled line counts

id before after diff
apm 80 78 -2
observability 45 44 -1
synthetics 59 53 -6
ux 10 9 -1
total -10

Total ESLint disabled count

id before after diff
apm 94 91 -3
observability 52 50 -2
synthetics 65 59 -6
ux 13 12 -1
total -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Agent activity flyout
3 participants