[Fleet] moved Agent activity and Add agent buttons to a new row above search bar #142046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
commented
Sep 28, 2022
| </EuiButton> | ||
| </EuiToolTip> | ||
| {(selectionMode === 'manual' && selectedAgents.length) || | ||
| (selectionMode === 'query' && totalAgents > 0) ? ( |
There was a problem hiding this comment.
small refactor to move the visibility condition of bulk action button to a more logical place, this fixes a small issue that the UI elements were not aligned (Add agent and Upgrade available box below)
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 28, 2022
… search bar (elastic#142046) * moved Agent activity and Add agent buttons to a new row above search bar * moved show bulk action button visibility logic one level up (cherry picked from commit 1717d61)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 28, 2022
… search bar (#142046) (#142149) * moved Agent activity and Add agent buttons to a new row above search bar * moved show bulk action button visibility logic one level up (cherry picked from commit 1717d61) Co-authored-by: Julia Bardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #140267
Moved Agent activity and Add agent, Add Fleet Server buttons to a new line above the search bar to match the new design.
Also fixes #141622
Design:
Implementation:
