fix: use correct name for CGroup memory limit metric #143833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems memory limit metrics is affected by the same issue of memory usage. The metric seems to plot beats_stats.metrics.beat.cgroup.memory.mem.limit.bytes but as per metricbeat documents the correct field should be either beats_stats.metrics.beat.cgroup.mem.limit.bytes or beat.stats.cgroup.memory.mem.limit.bytes. Update field name and tests accordingly.
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
|
Superseded by #143832 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems memory limit metrics is affected by the same issue of memory usage.
The metric seems to plot
beats_stats.metrics.beat.cgroup.memory.mem.limit.bytesbut as per metricbeat documents the correct field should be eitherbeats_stats.metrics.beat.cgroup.mem.limit.bytesorbeat.stats.cgroup.memory.mem.limit.bytes.Update field name and tests accordingly.
Related to elastic/apm-server#8596
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
For maintainers