Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Add aiAssistant:preferredAIAssistantType setting to settings page #190969

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Aug 21, 2024

This adds the aiAssistant:preferredAIAssistantType setting (aka "Observability AI Assistant scope") to the Obs AI Assistant settings page. It was not necessary to re-define the setting definition as it was already declared here

image

@sorenlouv sorenlouv requested a review from a team as a code owner August 21, 2024 11:29
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Aug 21, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Aug 27, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 27, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 9a4019d
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-190969-9a4019de7379

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observabilityAIAssistant 292 293 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAiAssistantManagement 91.5KB 91.5KB +38.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 47.0KB 47.1KB +146.0B
Unknown metric groups

API count

id before after diff
observabilityAIAssistant 294 295 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit eeed6c8 into elastic:main Aug 28, 2024
30 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 28, 2024
@sorenlouv sorenlouv deleted the add-assistant-scope-setting branch August 28, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants