Attempt to get rid of SavedObjectClass

src/plugins/dashboard/public/services/saved_objects_tagging/saved_objects_tagging.stub.ts

@@ -21,7 +21,6 @@ export const savedObjectsTaggingServiceFactory: SavedObjectsTaggingServiceFactor
 
     // I'm not defining components so that I don't have to update the snapshot of `save_modal.test`
     // However, if it's ever necessary, it can be done via: `components: pluginMock.components`,
-    hasTagDecoration: pluginMock.hasTagDecoration,
     parseSearchQuery: pluginMock.parseSearchQuery,
     getSearchBarFilter: pluginMock.getSearchBarFilter,
     getTagIdsFromReferences: pluginMock.getTagIdsFromReferences,

src/plugins/dashboard/public/services/saved_objects_tagging/saved_objects_tagging_service.ts

@@ -29,7 +29,6 @@ export const savedObjectsTaggingServiceFactory: SavedObjectsTaggingServiceFactor
     ui: {
       components,
       parseSearchQuery,
-      hasTagDecoration,
       getSearchBarFilter,
       updateTagsReferences,
       getTagIdsFromReferences,
@@ -42,7 +41,6 @@ export const savedObjectsTaggingServiceFactory: SavedObjectsTaggingServiceFactor
     hasApi: true,
     api: taggingApi,
     components,
-    hasTagDecoration,
     parseSearchQuery,
     getSearchBarFilter,
     updateTagsReferences,

src/plugins/dashboard/public/services/saved_objects_tagging/types.ts

@@ -13,7 +13,6 @@ export interface DashboardSavedObjectsTaggingService {
   hasApi: boolean; // remove this once the entire service is optional
   api?: SavedObjectsTaggingApi;
   components?: SavedObjectsTaggingApi['ui']['components'];
-  hasTagDecoration?: SavedObjectsTaggingApi['ui']['hasTagDecoration'];
   parseSearchQuery?: SavedObjectsTaggingApi['ui']['parseSearchQuery'];
   getSearchBarFilter?: SavedObjectsTaggingApi['ui']['getSearchBarFilter'];
   updateTagsReferences?: SavedObjectsTaggingApi['ui']['updateTagsReferences'];

src/plugins/saved_objects/kibana.jsonc

@@ -9,9 +9,6 @@
     "requiredPlugins": [
       "data",
       "dataViews"
-    ],
-    "requiredBundles": [
-      "kibanaUtils"
     ]
   }
 }

src/plugins/saved_objects/public/index.ts

@@ -11,13 +11,7 @@ import { SavedObjectsPublicPlugin } from './plugin';
 
 export type { OnSaveProps, OriginSaveModalProps, SaveModalState, SaveResult } from './save_modal';
 export { SavedObjectSaveModal, SavedObjectSaveModalOrigin, showSaveModal } from './save_modal';
-export type {
-  SavedObjectDecorator,
-  SavedObjectDecoratorFactory,
-  SavedObjectDecoratorConfig,
-} from './saved_object';
 export { checkForDuplicateTitle, saveWithConfirmation, isErrorNonFatal } from './saved_object';
 export type { SavedObjectSaveOpts, SavedObject, SavedObjectConfig } from './types';
-export type { SavedObjectsStart, SavedObjectSetup } from './plugin';
 
 export const plugin = () => new SavedObjectsPublicPlugin();

src/plugins/saved_objects/public/mocks.ts

@@ -7,21 +7,4 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { SavedObjectsStart, SavedObjectSetup } from './plugin';
-
-const createStartContract = (): SavedObjectsStart => {
-  return {
-    SavedObjectClass: jest.fn(),
-  };
-};
-
-const createSetupContract = (): jest.Mocked<SavedObjectSetup> => {
-  return {
-    registerDecorator: jest.fn(),
-  };
-};
-
-export const savedObjectsPluginMock = {
-  createStartContract,
-  createSetupContract,
-};
+export const savedObjectsPluginMock = {};

src/plugins/saved_objects/public/plugin.ts

@@ -12,55 +12,19 @@ import { CoreStart, Plugin } from '@kbn/core/public';
 import './index.scss';
 import { DataPublicPluginStart } from '@kbn/data-plugin/public';
 import { DataViewsPublicPluginStart } from '@kbn/data-views-plugin/public';
-import {
-  createSavedObjectClass,
-  SavedObjectDecoratorRegistry,
-  SavedObjectDecoratorConfig,
-} from './saved_object';
-import { SavedObject } from './types';
 import { setStartServices } from './kibana_services';
 
-export interface SavedObjectSetup {
-  registerDecorator: (config: SavedObjectDecoratorConfig<any>) => void;
-}
-
-export interface SavedObjectsStart {
-  /**
-   * @deprecated
-   * @removeBy 8.8.0
-   */
-  SavedObjectClass: new (raw: Record<string, any>) => SavedObject;
-}
-
 export interface SavedObjectsStartDeps {
   data: DataPublicPluginStart;
   dataViews: DataViewsPublicPluginStart;
 }
 
-export class SavedObjectsPublicPlugin
-  implements Plugin<SavedObjectSetup, SavedObjectsStart, object, SavedObjectsStartDeps>
-{
-  private decoratorRegistry = new SavedObjectDecoratorRegistry();
-
-  public setup(): SavedObjectSetup {
-    return {
-      registerDecorator: (config) => this.decoratorRegistry.register(config),
-    };
+export class SavedObjectsPublicPlugin implements Plugin<{}, {}, object, SavedObjectsStartDeps> {
+  public setup() {
+    return {};
   }
   public start(core: CoreStart, { data, dataViews }: SavedObjectsStartDeps) {
     setStartServices(core);
-    return {
-      SavedObjectClass: createSavedObjectClass(
-        {
-          dataViews,
-          savedObjectsClient: core.savedObjects.client,
-          search: data.search,
-          chrome: core.chrome,
-          overlays: core.overlays,
-        },
-        core,
-        this.decoratorRegistry
-      ),
-    };
+    return {};
   }
 }