[ES body removal] @elastic/kibana-core
#204851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
afharo
commented
Dec 20, 2024
packages/kbn-es-types/src/index.ts
Outdated
Comment on lines
10
to
13
| import * as estypes from '@elastic/elasticsearch/lib/api/types'; | ||
| // TODO: Remove when all usages have been migrated to non-body | ||
| import { SearchRequest as SearchRequestWithBodyKey } from '@elastic/elasticsearch/lib/api/typesWithBodyKey'; | ||
| import type { Field, QueryDslFieldAndFormat } from '@elastic/elasticsearch/lib/api/types'; |
There was a problem hiding this comment.
making no-body the default, and flagging the intention to remove the WithBody one when all other PRs are merged.
|
Pinging @elastic/kibana-core (Team:Core) |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@darnautov, I tried to submit one PR per code owner but unfortunately I ended up in a dead lock. The changes in this PR are as minimal as I could get to unblock this pr (that should unblock the rest). Apologies for the double ping. |
darnautov
approved these changes
Dec 24, 2024
dgieselaar
approved these changes
Dec 30, 2024
rmyz
approved these changes
Jan 7, 2025
dominiqueclarke
approved these changes
Jan 7, 2025
jloleysens
approved these changes
Jan 8, 2025
|
The build error is related to #206258. I'll rebase once it's merged. |
weltenwort
approved these changes
Jan 10, 2025
⏳ Build in-progress
History
cc @afharo |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 2cd882c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2025
…204851) (#206292) # Backport This will backport the following commits from `main` to `8.x`: - [[ES `body` removal] `@elastic/kibana-core` (#204851)](#204851) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T14:41:19Z","message":"[ES `body` removal] `@elastic/kibana-core` (#204851)","sha":"2cd882c50d01967a34d88463af630a8384fede9a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[ES `body` removal] `@elastic/kibana-core`","number":204851,"url":"https://github.com/elastic/kibana/pull/204851","mergeCommit":{"message":"[ES `body` removal] `@elastic/kibana-core` (#204851)","sha":"2cd882c50d01967a34d88463af630a8384fede9a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204851","number":204851,"mergeCommit":{"message":"[ES `body` removal] `@elastic/kibana-core` (#204851)","sha":"2cd882c50d01967a34d88463af630a8384fede9a"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempt to remove the deprecated
bodyin the ES client.There are some (documented in code comments) workarounds to be able to merge. The following PRs will address the removal of other teams' code:
bodyremoval]@elastic/ml-ui#204872bodyremoval]@elastic/obs-ux-management-team#204877bodyremoval]@elastic/obs-ux-logs-team#204863bodyremoval]@elastic/obs-ux-infra_services-team#204864