[Visual Refresh] behindText datavis and severity color cleanup #206061
+62
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
added
release_note:skip
mgadewoll
force-pushed
the
eui/162-163-behindText-and-severity-color-cleanup
branch
from
9fe0a01 to
a5ce42e
Compare
|
Pinging @elastic/eui-team (EUI) |
mgadewoll
force-pushed
the
eui/162-163-behindText-and-severity-color-cleanup
branch
from
a5ce42e to
f47b5d6
Compare
botelastic
bot
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
MiriamAparicio
approved these changes
Jan 15, 2025
- reverts Amsterdam colors of previously changed usages by using conditions; uses new available tokens
mgadewoll
force-pushed
the
eui/162-163-behindText-and-severity-color-cleanup
branch
from
f47b5d6 to
e7478b0
Compare
💔 Build Failed
Failed CI StepsMetrics [docs]Async chunks
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds cleanups to previously merged Borealis-related updates to usages of severity colors and/or
behindTextdata vis colors as EUI provides matching tokens and initial guidance on usage by now (see point 5) in this FAQ for the guidance).These updates ensure that we keep parity for Amsterdam colors by using conditional updates while using semantic tokens for Borealis.
Note
Please let me know in case your team already made those changes or has other plans for the code.
ℹ️ Management changes were done separately by the team itself here.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.