[Streams] Refactoring streams routes #206526
Merged
+635
−749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-refactor-routes
…3-refactor-routes
simianhacker
added
release_note:skip
tonyghiani
reviewed
Jan 14, 2025
There was a problem hiding this comment.
The simulateProcessorRoute registration has gone lost, might be good to move it to the management folder, wdyt?
There was a problem hiding this comment.
Whoops... I should have moved this back to "Draft". I just added those while you were reviewing it.
…3-refactor-routes
|
This is gonna clash a bit with #206438 , but I'd argue it makes it better because Darios PR moves a bunch of logic out of the route handlers into the streams client, so the consolidated I like the new separation, I would argue |
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
## Summary This PR consolidates the multiple `server/streams/*` route files into 4 `route.ts` files to optimize the Typescript parsing. I tried to organize the routes into 4 logical groups: - CRUD - edit, list, read, delete - Management - fork, resync, status, sample - Schema - unmapped fields, schema simulation - Enablement - disable, enable I left everything else "as is" since @dgieselaar is currently doing a refactor to consolidate most of the features into a new `StreamsClient` similar to the `AssetClient` (cherry picked from commit 24f5153)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Refactoring streams routes (#206526)](#206526) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Chris Cowan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T16:53:01Z","message":"[Streams] Refactoring streams routes (#206526)\n\n## Summary\r\n\r\nThis PR consolidates the multiple `server/streams/*` route files into 4\r\n`route.ts` files to optimize the Typescript parsing. I tried to organize\r\nthe routes into 4 logical groups:\r\n\r\n- CRUD - edit, list, read, delete\r\n- Management - fork, resync, status, sample\r\n- Schema - unmapped fields, schema simulation\r\n- Enablement - disable, enable\r\n\r\nI left everything else \"as is\" since @dgieselaar is currently doing a\r\nrefactor to consolidate most of the features into a new `StreamsClient`\r\nsimilar to the `AssetClient`","sha":"24f5153d8505714cd953bdf7c529131a29c2c7ca","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:Streams"],"title":"[Streams] Refactoring streams routes","number":206526,"url":"https://github.com/elastic/kibana/pull/206526","mergeCommit":{"message":"[Streams] Refactoring streams routes (#206526)\n\n## Summary\r\n\r\nThis PR consolidates the multiple `server/streams/*` route files into 4\r\n`route.ts` files to optimize the Typescript parsing. I tried to organize\r\nthe routes into 4 logical groups:\r\n\r\n- CRUD - edit, list, read, delete\r\n- Management - fork, resync, status, sample\r\n- Schema - unmapped fields, schema simulation\r\n- Enablement - disable, enable\r\n\r\nI left everything else \"as is\" since @dgieselaar is currently doing a\r\nrefactor to consolidate most of the features into a new `StreamsClient`\r\nsimilar to the `AssetClient`","sha":"24f5153d8505714cd953bdf7c529131a29c2c7ca"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206526","number":206526,"mergeCommit":{"message":"[Streams] Refactoring streams routes (#206526)\n\n## Summary\r\n\r\nThis PR consolidates the multiple `server/streams/*` route files into 4\r\n`route.ts` files to optimize the Typescript parsing. I tried to organize\r\nthe routes into 4 logical groups:\r\n\r\n- CRUD - edit, list, read, delete\r\n- Management - fork, resync, status, sample\r\n- Schema - unmapped fields, schema simulation\r\n- Enablement - disable, enable\r\n\r\nI left everything else \"as is\" since @dgieselaar is currently doing a\r\nrefactor to consolidate most of the features into a new `StreamsClient`\r\nsimilar to the `AssetClient`","sha":"24f5153d8505714cd953bdf7c529131a29c2c7ca"}}]}] BACKPORT--> Co-authored-by: Chris Cowan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the multiple
server/streams/*route files into 4route.tsfiles to optimize the Typescript parsing. I tried to organize the routes into 4 logical groups:I left everything else "as is" since @dgieselaar is currently doing a refactor to consolidate most of the features into a new
StreamsClientsimilar to theAssetClient