Fix 8.x 9 forward compat tests #206624
Merged
Fix 8.x 9 forward compat tests #206624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
|
afharo
approved these changes
Jan 15, 2025
afharo
approved these changes
Jan 15, 2025
Comment on lines
+73
to
+75
| willRunESv9 | ||
| ? '8.18.0_xpack_sample_saved_objects.zip' | ||
| : '7.14.0_xpack_sample_saved_objects.zip' |
jloleysens
added a commit
that referenced
this pull request
Jan 22, 2025
## Summary Follow up from #206624 aimed at fixing failing compat tests: https://buildkite.com/elastic/kibana-es-forward-compatibility-testing-9-dot-0/builds?branch=8.x ### Core * Fixed jest integration tests, generated new archives * Skipped the UA tests for 8.x -> 9 if ES >8, I assume these tests only make sense if ES is on v8 ### Security solution ES|QL * Made the `metadata [...` test only run when ES is v8 ### Kibana management * Made the unfreeze test only run when ES is v8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix 8.x -> 9 forward compatibility test scenarios:
Using the
EsVersionclass to detect the version of ES that will be run and skipping these tests.Test locally
Simulate what the buildkite pipeline is doing locally and the entire suite should report being skipped.
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" yarn test:jest_integration ./src/core/server/integration_tests/saved_objects/migrations/group3/migration_from_older_v1.test.tsSimulate what the buildkite pipeline is doing locally, should pass (instead of break due to incompatible data).
ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/9.0.0/manifest-latest-verified.json" yarn test:jest_integration src/core/server/integration_tests/saved_objects/migrations/group2/batch_size_bytes.test.ts