Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix: Add tracing sample missing fields in the overview #206932

Merged
merged 14 commits into from
Jan 16, 2025
Merged

[APM] Fix: Add tracing sample missing fields in the overview #206932

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6d9a8ca
Revert "[ECO][Inventory v2] Ad hoc data view: Add get entities defini…
jennypavlova Dec 12, 2024
d2672d9
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Dec 13, 2024
32a5fc4
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 2, 2025
7d27dcb
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 3, 2025
c2b62a0
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 7, 2025
299b233
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 8, 2025
57c5eac
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 8, 2025
19b7967
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 13, 2025
565a83a
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 13, 2025
8a82e1c
Merge branch 'main' of github.com:elastic/kibana
jennypavlova Jan 15, 2025
e700868
Fix: APM Tracing sample missing URL/Status Code/User Agent fields in …
jennypavlova Jan 16, 2025
228e8e0
Merge branch 'main' into 200474-apm-tracing-fix-sample-missing-urlsta…
jennypavlova Jan 16, 2025
c0bd76d
Update test snapshot
jennypavlova Jan 16, 2025
07111dc
Merge branch 'main' into 200474-apm-tracing-fix-sample-missing-urlsta…
jennypavlova Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ck/solutions/observability/packages/kbn-apm-types/src/es_schemas/raw/fields/user_agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface UserAgent {
name: string;
};
name?: string;
original: string;
original?: string;
os?: {
name: string;
version?: string;
Expand Down
15 changes: 14 additions & 1 deletion ...k/solutions/observability/plugins/apm/server/routes/transactions/get_transaction/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ import {
SPAN_LINKS,
TRANSACTION_AGENT_MARKS,
SERVICE_LANGUAGE_NAME,
URL_FULL,
HTTP_REQUEST_METHOD,
HTTP_RESPONSE_STATUS_CODE,
TRANSACTION_PAGE_URL,
USER_AGENT_NAME,
} from '../../../../common/es_fields/apm';
import { asMutableArray } from '../../../../common/utils/as_mutable_array';
import type { APMEventClient } from '../../../lib/helpers/create_es_client/create_apm_event_client';
Expand Down Expand Up @@ -58,7 +63,15 @@ export async function getTransaction({
TRANSACTION_TYPE,
] as const);

const optionalFields = asMutableArray([PROCESSOR_NAME, SERVICE_LANGUAGE_NAME] as const);
const optionalFields = asMutableArray([
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These errors keep happening ever since we adapted the code to support otel, could we add a test to validate whether these fields are returned in the response?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea, thanks! As this is a blocker for some users I would do it in a separate PR: I added an issue: #206947

PROCESSOR_NAME,
SERVICE_LANGUAGE_NAME,
URL_FULL,
TRANSACTION_PAGE_URL,
HTTP_RESPONSE_STATUS_CODE,
HTTP_REQUEST_METHOD,
USER_AGENT_NAME,
] as const);

const resp = await apmEventClient.search('get_transaction', {
apm: {
Expand Down