Revert "[8.17] [search profiler] Move profile button inline with index field (#202253)" #208650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x field …" This reverts commit 4b08613.
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
|
mattkime
added
backport:skip
sabarasaba
reviewed
Jan 29, 2025
| @@ -141,21 +118,6 @@ export const ProfileQueryEditor = memo(() => { | |||
| /> | |||
| </EuiFormRow> | |||
| </EuiFlexItem> | |||
| <EuiFlexItem grow={false}> | |||
There was a problem hiding this comment.
dont we wanna leave the EuiIconButton here instead? Otherwise we will endup with a different version of the UI for 8.17.. given that both main and the 8.16 backport have the IconButton instead
There was a problem hiding this comment.
Yes, I'll create a new PR that's about the same as the 8.16 backport.
sabarasaba
approved these changes
Jan 29, 2025
mattkime
added a commit
that referenced
this pull request
Jan 30, 2025
…202253) (#208821) # Backport This will backport the following commits from `main` to `8.17`: - [[search profiler] Move profile button inline with index field (#202253)](#202253) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-22T04:01:43Z","message":"[search profiler] Move profile button inline with index field (#202253)\n\n## Summary\r\n\r\nAt smaller window sizes, the `Profile` button disappears beneath the\r\ncode editor. Lets move it to the top and shrink it.\r\n\r\n<img width=\"1051\" alt=\"Screenshot 2024-11-30 at 11 47 27 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\">","sha":"c12c88d243840d498b767a5f9b29f2748d4b2ff3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Search Profiler","backport missing","v9.0.0","backport:prev-major","v8.18.0","v8.16.4","v8.17.2"],"title":"[search profiler] Move profile button inline with index field","number":202253,"url":"https://github.com/elastic/kibana/pull/202253","mergeCommit":{"message":"[search profiler] Move profile button inline with index field (#202253)\n\n## Summary\r\n\r\nAt smaller window sizes, the `Profile` button disappears beneath the\r\ncode editor. Lets move it to the top and shrink it.\r\n\r\n<img width=\"1051\" alt=\"Screenshot 2024-11-30 at 11 47 27 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\">","sha":"c12c88d243840d498b767a5f9b29f2748d4b2ff3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202253","number":202253,"mergeCommit":{"message":"[search profiler] Move profile button inline with index field (#202253)\n\n## Summary\r\n\r\nAt smaller window sizes, the `Profile` button disappears beneath the\r\ncode editor. Lets move it to the top and shrink it.\r\n\r\n<img width=\"1051\" alt=\"Screenshot 2024-11-30 at 11 47 27 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\">","sha":"c12c88d243840d498b767a5f9b29f2748d4b2ff3"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/207648","number":207648,"state":"MERGED","mergeCommit":{"sha":"5db51893984383cfd76eeb91a63ec23cfaa32f50","message":"[8.x] [search profiler] Move profile button inline with index field (#202253) (#207648)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[search profiler] Move profile button inline with index field\n(#202253)](https://github.com/elastic/kibana/pull/202253)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Matthew\nKime\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-22T04:01:43Z\",\"message\":\"[search\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Kibana\nManagement\",\"release_note:skip\",\"Feature:Search\nProfiler\",\"v9.0.0\",\"backport:prev-major\"],\"title\":\"[search profiler]\nMove profile button inline with index\nfield\",\"number\":202253,\"url\":\"https://github.com/elastic/kibana/pull/202253\",\"mergeCommit\":{\"message\":\"[search\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/202253\",\"number\":202253,\"mergeCommit\":{\"message\":\"[search\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Matthew Kime <[email protected]>"}},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208480","number":208480,"state":"MERGED","mergeCommit":{"sha":"c38604245273dd3e40e15e308828178f2d9788b8","message":"[8.16] [search profiler] Move profile button inline with index field (#202253) (#208480)\n\n# Backport\r\n\r\nThis will backport the following commits from `main` to `8.16`:\r\n- [[search profiler] Move profile button inline with index field\r\n(#202253)](https://github.com/elastic/kibana/pull/202253)\r\n\r\n<!--- Backport version: 9.6.4 -->\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sorenlouv/backport)\r\n\r\n<!--BACKPORT [{\"author\":{\"name\":\"Matthew\r\nKime\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-01-22T04:01:43Z\",\"message\":\"[search\r\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\r\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\r\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\r\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\r\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Kibana\r\nManagement\",\"release_note:skip\",\"Feature:Search\r\nProfiler\",\"v9.0.0\",\"backport:prev-major\",\"v8.18.0\"],\"title\":\"[search\r\nprofiler] Move profile button inline with index\r\nfield\",\"number\":202253,\"url\":\"https://github.com/elastic/kibana/pull/202253\",\"mergeCommit\":{\"message\":\"[search\r\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\r\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\r\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\r\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\r\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/202253\",\"number\":202253,\"mergeCommit\":{\"message\":\"[search\r\nprofiler] Move profile button inline with index field (#202253)\\n\\n##\r\nSummary\\r\\n\\r\\nAt smaller window sizes, the `Profile` button disappears\r\nbeneath the\\r\\ncode editor. Lets move it to the top and shrink\r\nit.\\r\\n\\r\\n<img width=\\\"1051\\\" alt=\\\"Screenshot 2024-11-30 at 11 47\r\n27 PM\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\">\",\"sha\":\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\"}},{\"branch\":\"8.x\",\"label\":\"v8.18.0\",\"branchLabelMappingKey\":\"^v8.18.0$\",\"isSourceBranch\":false,\"url\":\"https://github.com/elastic/kibana/pull/207648\",\"number\":207648,\"state\":\"MERGED\",\"mergeCommit\":{\"sha\":\"5db51893984383cfd76eeb91a63ec23cfaa32f50\",\"message\":\"[8.x]\r\n[search profiler] Move profile button inline with index field (#202253)\r\n(#207648)\\n\\n# Backport\\n\\nThis will backport the following commits from\r\n`main` to `8.x`:\\n- [[search profiler] Move profile button inline with\r\nindex\r\nfield\\n(#202253)](https://github.com/elastic/kibana/pull/202253)\\n\\n<!---\r\nBackport version: 9.4.3 -->\\n\\n### Questions ?\\nPlease refer to the\r\n[Backport\r\ntool\\ndocumentation](https://github.com/sqren/backport)\\n\\n<!--BACKPORT\r\n[{\\\"author\\\":{\\\"name\\\":\\\"Matthew\\nKime\\\",\\\"email\\\":\\\"[email protected]\\\"},\\\"sourceCommit\\\":{\\\"committedDate\\\":\\\"2025-01-22T04:01:43Z\\\",\\\"message\\\":\\\"[search\\nprofiler]\r\nMove profile button inline with index field\r\n(#202253)\\\\n\\\\n##\\nSummary\\\\r\\\\n\\\\r\\\\nAt smaller window sizes, the\r\n`Profile` button disappears\\nbeneath the\\\\r\\\\ncode editor. Lets move it\r\nto the top and shrink\\nit.\\\\r\\\\n\\\\r\\\\n<img width=\\\\\\\"1051\\\\\\\"\r\nalt=\\\\\\\"Screenshot 2024-11-30 at 11\r\n47\\n27 PM\\\\\\\"\\\\r\\\\nsrc=\\\\\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\\\\\">\\\",\\\"sha\\\":\\\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\\\",\\\"branchLabelMapping\\\":{\\\"^v9.0.0$\\\":\\\"main\\\",\\\"^v8.18.0$\\\":\\\"8.x\\\",\\\"^v(\\\\\\\\d+).(\\\\\\\\d+).\\\\\\\\d+$\\\":\\\"$1.$2\\\"}},\\\"sourcePullRequest\\\":{\\\"labels\\\":[\\\"Team:Kibana\\nManagement\\\",\\\"release_note:skip\\\",\\\"Feature:Search\\nProfiler\\\",\\\"v9.0.0\\\",\\\"backport:prev-major\\\"],\\\"title\\\":\\\"[search\r\nprofiler]\\nMove profile button inline with\r\nindex\\nfield\\\",\\\"number\\\":202253,\\\"url\\\":\\\"https://github.com/elastic/kibana/pull/202253\\\",\\\"mergeCommit\\\":{\\\"message\\\":\\\"[search\\nprofiler]\r\nMove profile button inline with index field\r\n(#202253)\\\\n\\\\n##\\nSummary\\\\r\\\\n\\\\r\\\\nAt smaller window sizes, the\r\n`Profile` button disappears\\nbeneath the\\\\r\\\\ncode editor. Lets move it\r\nto the top and shrink\\nit.\\\\r\\\\n\\\\r\\\\n<img width=\\\\\\\"1051\\\\\\\"\r\nalt=\\\\\\\"Screenshot 2024-11-30 at 11\r\n47\\n27 PM\\\\\\\"\\\\r\\\\nsrc=\\\\\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\\\\\">\\\",\\\"sha\\\":\\\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\\\"}},\\\"sourceBranch\\\":\\\"main\\\",\\\"suggestedTargetBranches\\\":[],\\\"targetPullRequestStates\\\":[{\\\"branch\\\":\\\"main\\\",\\\"label\\\":\\\"v9.0.0\\\",\\\"branchLabelMappingKey\\\":\\\"^v9.0.0$\\\",\\\"isSourceBranch\\\":true,\\\"state\\\":\\\"MERGED\\\",\\\"url\\\":\\\"https://github.com/elastic/kibana/pull/202253\\\",\\\"number\\\":202253,\\\"mergeCommit\\\":{\\\"message\\\":\\\"[search\\nprofiler]\r\nMove profile button inline with index field\r\n(#202253)\\\\n\\\\n##\\nSummary\\\\r\\\\n\\\\r\\\\nAt smaller window sizes, the\r\n`Profile` button disappears\\nbeneath the\\\\r\\\\ncode editor. Lets move it\r\nto the top and shrink\\nit.\\\\r\\\\n\\\\r\\\\n<img width=\\\\\\\"1051\\\\\\\"\r\nalt=\\\\\\\"Screenshot 2024-11-30 at 11\r\n47\\n27 PM\\\\\\\"\\\\r\\\\nsrc=\\\\\\\"https://github.com/user-attachments/assets/1d8b99cd-1b07-43cc-8d75-597b37f74e59\\\\\\\">\\\",\\\"sha\\\":\\\"c12c88d243840d498b767a5f9b29f2748d4b2ff3\\\"}}]}]\\nBACKPORT-->\\n\\nCo-authored-by:\r\nMatthew Kime <[email protected]>\"}}]}] BACKPORT-->\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>"}},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/208650","number":208650,"state":"MERGED","mergeCommit":{"sha":"a50aa46a20724e01ef3e08d97cc65388a25966e1","message":"Revert \"[8.17] [search profiler] Move profile button inline with index field (#202253)\" (#208650)\n\nReverts #207877\r\n\r\nToo many changes for a patch release. Going to backport a subset of\r\n#202253"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #207877
Too many changes for a patch release. Going to backport a subset of #202253