Upgrade EUI to v99.2.0-borealis.0 #209690
Open
+683
−678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkajtoch
force-pushed
the
feat/eui-v99.2.0
branch
from
4c1d4f8 to
980eee2
Compare
tkajtoch
force-pushed
the
feat/eui-v99.2.0
branch
from
980eee2 to
7c62af4
Compare
|
@elasticmachine merge upstream |
|
Pinging @elastic/eui-team (EUI) |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @tkajtoch |
botelastic
bot
added
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
crespocarlos
approved these changes
Feb 10, 2025
jeramysoucy
approved these changes
Feb 10, 2025
| @@ -78,7 +78,7 @@ test('updates identifier, initials and color when name is changed', () => { | |||
| id: 'space-2', | |||
| name: 'Space 2', | |||
| initials: 'S2', | |||
| color: '#9170B8', | |||
| color: '#BFDBFF', | |||
There was a problem hiding this comment.
Nit: it would be nice if these color values were constants somewhere that could be referenced across all tests.
peteharverson
approved these changes
Feb 10, 2025
nickofthyme
approved these changes
Feb 10, 2025
| { key: '8,529.2 - 11,335.66', name: '8,529.2 - 11,335.66', color: '#c8deff' }, | ||
| { key: '11,335.66 - 14,142.1', name: '11,335.66 - 14,142.1', color: '#f6f9fc' }, | ||
| { key: '14,142.1 - 16,948.55', name: '14,142.1 - 16,948.55', color: '#ffccc6' }, | ||
| { key: '7,747 - 8,529.2', name: '7,747 - 8,529.2', color: '#61a2ff' }, |
There was a problem hiding this comment.
Not sure why this label would change here?
tkajtoch
added
backport:version
Ikuni17
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99.1.0-borealis.0⏩99.2.0-borealis.0Questions? Please see our Kibana upgrade FAQ.
v99.2.0EuiFieldTextstyles to prioritizedisabledstyling overreadonly. (#8271)plugsandwebglyphs toEuiIcon(#8285)titleonEuiColorPalettePickerPalettePropsto be optional (#8289)Bug fixes
disabledbehavior ofEuiFieldTextto prevent input changes. (#8271)Borealis changes
As you can probably tell, there are plenty of updated tests and snapshots this time around. They are the result of the following:
@elastic/euiv99.2.0 to Borealis, which led to kibana tests usingrenderWithTheme,mountWithTheme, and other utility functions that wrap the tested component in<EuiThemeProvider>to switch to the correct, new color values. With this change, all tests should now use Borealis, regardless of the testing framework or its configuration.css-wprskz-euiButtonIcon-xs-empty-primary) regenerated.Most Borealis-related changes in this PR are test env only and have no impact on what users see when using Kibana.