-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known issue for PipelineBusv2 to 8.15.x release notes #16661
Conversation
@yaauie Can you update the issue name please - the automatic issue namer kicked in with the two commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left suggestions for consideration and discussion in the 8.15.0 section.
When we nail down the content, we can add it to other sections.
LMKWYT
Co-authored-by: Karen Metts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy-pasted the deltas in review from 8.15.0 to the other sections, and removed a duplicate link to the issue.
In the 8.15.1 notes, this entry is bulleted but otherwise unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had added comments that we had double entries for 8.15.1 and no entries for 8.15.2, but it appears that issue got resolved while I was reviewing.
Now it appears that the only change needed is to remove the +
but keep the line as indicated inline.
I think we're close, but I'll verify in the preview and then sign off.
@@ -172,6 +196,14 @@ If this situation occurs, {ls} may fail to start or some plugins may use a malfo | |||
Check out issue https://github.com/elastic/logstash/issues/16437[#16437] for details. | |||
+ | |||
Workaround: Downgrade to {ls} 8.15.0, or temporarily avoid using environment and keystore variable references. | |||
* **{ls} can fail to shut down under some circumstances when you are using <<pipeline-to-pipeline>>.** | |||
Check out issue https://github.com/elastic/logstash/issues/16657[#16657] for details. | |||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is necessary because it's in a bulleted list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested removing the bullet because it was a single item. When the bullet went away, the +
needed to go away, too, to avoid it rendering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the +
should go, but the line should remain to force rendering into two distinct paragraphs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing newline consistency before next header
formatting: - plus-to-continue only in lists, - consistency of linebreaks before next section Co-authored-by: Karen Metts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's go with what we have.
I'll tweak it later.
@logstashmachine backport 8.16 |
Release notes
[rn: skip]
What does this PR do?
Adds release notes for the #16657 known issue in v2 of the pipeline bus which can prevent shutdown.