Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject VERSION_QUALIFIER into artifacts #16904

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Jan 16, 2025

logstash-core/logstash-core.gemspec Outdated Show resolved Hide resolved
logstash-core-plugin-api/logstash-core-plugin-api.gemspec Outdated Show resolved Hide resolved
else
PACKAGE_SUFFIX = SNAPSHOT_BUILD ? "-SNAPSHOT" : ""
end
PACKAGE_SUFFIX = SNAPSHOT_BUILD ? "-SNAPSHOT" : ""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need to add the qualifier to the artifact's name explictly here, since it will be added already through the version yml.

@jsvd jsvd marked this pull request as ready for review January 16, 2025 15:39
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks like the right update. One suggestion is https://github.com/elastic/logstash/pull/16904/files#r1919366815 but take it or leave it!

@jsvd jsvd force-pushed the inject_qualifier_version branch from c17d28c to 480879a Compare January 17, 2025 09:58
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jsvd jsvd merged commit 9a2cd01 into elastic:main Jan 17, 2025
5 of 6 checks passed
@jsvd jsvd deleted the inject_qualifier_version branch January 17, 2025 10:18
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inject VERSION_QUALIFIER into the build to be displayed to users
3 participants