-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inject VERSION_QUALIFIER into artifacts #16904
Conversation
else | ||
PACKAGE_SUFFIX = SNAPSHOT_BUILD ? "-SNAPSHOT" : "" | ||
end | ||
PACKAGE_SUFFIX = SNAPSHOT_BUILD ? "-SNAPSHOT" : "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to add the qualifier to the artifact's name explictly here, since it will be added already through the version yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks like the right update. One suggestion is https://github.com/elastic/logstash/pull/16904/files#r1919366815 but take it or leave it!
c17d28c
to
480879a
Compare
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
|
fixes #16898
Exhaustive test suite run: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1131