Introduce a new operation to benchmark the shard changes recovery api #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
reviewed
Jan 15, 2025
|
@elasticmachine update branch |
martijnvg
approved these changes
Jan 15, 2025
salvatore-campagna
changed the title
martijnvg
reviewed
Jan 22, 2025
| "index": "logs-*", | ||
| "operation": "refresh" | ||
| }, | ||
| { |
There was a problem hiding this comment.
I don't think we need to these operations related to merging? It just makes this challenge run longer?
| "name": "refresh-after-index", | ||
| "operation": "refresh" | ||
| }, | ||
| { |
There was a problem hiding this comment.
I think we can remove force-merge and wait-until-merges-finish here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR elastic/elasticsearch#118608, we introduced a new API that we would like to benchmark in order to evaluate the latency of synthetic source recovery. This benchmarking will help us assess how the API latency evolves over time and understand the potential impact of new features on recovery latency. The targets for this benchmark will include indices or data streams in the
elastic/logs,elastic/security, andtsdbtracks.Retention Lease Requirement:
It is important to add a retention lease before starting document indexing. This is necessary for ensuring that the subsequent shard recovery API call executes successfully without missing
seq_novalues. A missing retention lease may result in missingseq_novalues during shard recovery.Support for Data Streams and Index Aliases:
We extended the original API in PR elastic/elasticsearch#118937 to support data streams and index aliases. This extension is necessary for data stream use cases, as the backing index name may change depending on when the index is created. Supporting data streams and aliases simplifies benchmarking and provides greater flexibility in targeting indices.