Add lambda timeout option #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca <[email protected]>
Signed-off-by: constanca <[email protected]>
emilioalvap
reviewed
Jun 27, 2024
variables.tf
Outdated
| variable "lambda-timeout" { | ||
| description = "The amount of time your Lambda Function has to run in seconds." | ||
| type = number | ||
| default = 3 |
There was a problem hiding this comment.
@constanca-m Considering the kind of error that lambda timeout triggers and the difficulty in correlating them, I'd suggest keeping this to 15 min, in line to what the SAR deployment is doing:
ApplicationElasticServerlessForwarder:
Type: AWS::Serverless::Function
Properties:
Timeout: 900
MemorySize: 512
CodeUri:
Bucket: <%REPO_BUCKET%>
Key: ae7562c6-4e78-4865-91a9-968459fba0ab
Coincidentally, this PR will supersede #12.
There was a problem hiding this comment.
Yes, I agree, thank you for checking!! I updated it now to 900s as well
There was a problem hiding this comment.
Oh I had not noticed your PR. Do you want to have the 900s as an option or not? Otherwise I will just approve yours @emilioalvap
There was a problem hiding this comment.
@constanca-m No worries, I think providing the option is a better approach, I'll close mine
Signed-off-by: constanca <[email protected]>
emilioalvap
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom timeout option for the lambda.
This issue comes from elastic/elastic-serverless-forwarder#729 (comment).
This option is not available on SAR from what I have seen.
Just add:
And in AWS you should see in your lambda configuration:
