Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to protocol 6 #451

Merged
merged 8 commits into from
Nov 2, 2023
Merged

Switch to protocol 6 #451

merged 8 commits into from
Nov 2, 2023

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented Oct 17, 2023

No description provided.

@dimuon dimuon force-pushed the switch-to-protocol6 branch from 216cffc to 37c88ff Compare October 17, 2023 09:40
@dimuon
Copy link
Contributor Author

dimuon commented Oct 17, 2023

Kibana SLO tests fail for 8.10.3 - have to investigate.

@taylor-swanson
Copy link
Contributor

Kibana SLO tests fail for 8.10.3 - have to investigate.

As an FYI, I noticed these tests failing in my other PRs (#447 and #448), so don't think they're related to this change, but rather something to do with stack version 8.10.x.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM. Would be worth a changelog, and an update to the provider docs mentioning TF 1.0+ as a requirement.

@dimuon dimuon force-pushed the switch-to-protocol6 branch from f4dd8a1 to 1f34a71 Compare November 1, 2023 15:49
@dimuon
Copy link
Contributor Author

dimuon commented Nov 1, 2023

@tobio , I addressed your comment, would you mind to approve the PR?

tobio
tobio previously approved these changes Nov 2, 2023
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dimuon
Copy link
Contributor Author

dimuon commented Nov 2, 2023

@tobio , looks like I need your approve one more time - I had to resolve a conflict in CHANGELOG after the 0.10.0 release so your last review was dismissed.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still lgtm

@dimuon dimuon merged commit e4e1d06 into elastic:main Nov 2, 2023
@dimuon dimuon deleted the switch-to-protocol6 branch November 2, 2023 11:22
daemitus pushed a commit to daemitus/terraform-provider-elasticstack that referenced this pull request Nov 30, 2023
* Switch to protocol 6
* Update Stack version to 8.10.3
daemitus pushed a commit to daemitus/terraform-provider-elasticstack that referenced this pull request Nov 30, 2023
* Switch to protocol 6
* Update Stack version to 8.10.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants