-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to protocol 6 #451
Switch to protocol 6 #451
Conversation
216cffc
to
37c88ff
Compare
Kibana SLO tests fail for 8.10.3 - have to investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change LGTM. Would be worth a changelog, and an update to the provider docs mentioning TF 1.0+ as a requirement.
f4dd8a1
to
1f34a71
Compare
@tobio , I addressed your comment, would you mind to approve the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@tobio , looks like I need your approve one more time - I had to resolve a conflict in CHANGELOG after the 0.10.0 release so your last review was dismissed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still lgtm
* Switch to protocol 6 * Update Stack version to 8.10.3
* Switch to protocol 6 * Update Stack version to 8.10.3
No description provided.