-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health endpoint #3
Conversation
Nice, thank you! And thank you for adding to and improving the tests, too. This needs just one more thing for our use case: a run-time flag to override the default To satisfy everyone posting in CrunchyData#131 there should also be a way to specify additional paths to the health endpoint. But I'm inclined to leave that as an exercise for someone who needs it, and/or me later on volunteer time outside the scope of the project which is funding this bit. Just adding the flag will satisfy our use case and the majority of other peoples'. |
@eldang let me know how that flag suits you! |
Perfect, thank you. I'm going to merge the PR within this repo now, and then would you like to make the PR to the upstream repository? It seems appropriate for you to get the credit having done the work. |
Not deleting the branch because it may be tidier to make the PR to upstream from this than from local-main. |
ah, cool, I'll make the PR! |
I added a few tests and a very simple, configurable health check endpoint. Can you take a look at this and tell me if I'm on the right track? Or even test it out and see if it does what you want?