-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csp directive #2005
Merged
Merged
Csp directive #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for their applicaiton
arunvishnun
reviewed
Feb 28, 2024
LGTM in general, seems there is lint issues (spacings) |
arunvishnun
reviewed
Feb 28, 2024
Thank you @jchip, I shall update the code accordingly. |
divyakarippath
approved these changes
Feb 29, 2024
@RahulTinku Could you create change files. |
arunvishnun
approved these changes
Mar 1, 2024
Hi @arunvishnun , I have added changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ablity for applications to set their CSP headers which may include style-src & script-src. Applications can set their nonce value or use default nonce value provided by electrode as usual.
getCSPHeader is added in route options, which accepts a function. In this function application can generate the CSP and return it as string.