Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csp directive #2005

Merged
merged 10 commits into from
Mar 4, 2024
Merged

Csp directive #2005

merged 10 commits into from
Mar 4, 2024

Conversation

RahulTinku
Copy link
Contributor

Add ablity for applications to set their CSP headers which may include style-src & script-src. Applications can set their nonce value or use default nonce value provided by electrode as usual.

getCSPHeader is added in route options, which accepts a function. In this function application can generate the CSP and return it as string.

@RahulTinku RahulTinku requested a review from a team as a code owner February 28, 2024 09:16
@arunvishnun
Copy link
Contributor

LGTM in general, seems there is lint issues (spacings)

@jchip
Copy link
Member

jchip commented Feb 28, 2024

Screenshot 2024-02-28 at 2 13 45 PM

from ChatGPT.

@RahulTinku
Copy link
Contributor Author

Thank you @jchip, I shall update the code accordingly.

@arunvishnun
Copy link
Contributor

arunvishnun commented Mar 1, 2024

@RahulTinku Could you create change files.

@RahulTinku
Copy link
Contributor Author

Hi @arunvishnun , I have added changelog.
Thanks

@shubham2811 shubham2811 merged commit c912c9f into electrode-io:master Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants