feat: use reclient on init instead of goma #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is hanging on this, but can't tell if it's legitimate or something flaky, CI on other PRs are being quite slow at the moment as well. |
|
Might not just be CI? The code changes in this PR look fine, so my guess (w/o having looked at the test) is that the test just needs to be updated |
|
Could be hanging on a reclient auth request? |
MarshallOfSound
force-pushed
the
reclient-init
branch
from
5d8fc06 to
4055a3d
Compare
|
Was indeed hanging on the reclient auth request, so I pushed a commit to skip it during tests. |
dsanders11
approved these changes
Jan 13, 2024
codebytere
approved these changes
Jan 15, 2024
jkleinsc
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title, init should use reclient now