Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow deleting old Xcode versions #547

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jan 18, 2024

Closes #539.

Adds a new config preference to optionally delete unused Xcode versions to save disk space.

@codebytere codebytere requested a review from dsanders11 January 18, 2024 09:23
@codebytere codebytere requested review from ckerr and a team as code owners January 18, 2024 09:23
@@ -4,7 +4,6 @@ const childProcess = require('child_process');
const fs = require('fs');
const program = require('commander');
const path = require('path');
const os = require('os');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

@codebytere codebytere force-pushed the optionally-delete-old-xcodes branch 2 times, most recently from 48f4437 to 62fcd66 Compare January 18, 2024 15:34
@codebytere codebytere force-pushed the optionally-delete-old-xcodes branch from 62fcd66 to 0952051 Compare January 18, 2024 17:24
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one change to enforce valid values for the config option.

evm-config.schema.json Outdated Show resolved Hide resolved
evm-config.schema.json Outdated Show resolved Hide resolved
src/utils/xcode.js Outdated Show resolved Hide resolved
codebytere and others added 3 commits January 18, 2024 20:02
Co-authored-by: Samuel Attard <[email protected]>
Co-authored-by: David Sanders <[email protected]>
Co-authored-by: David Sanders <[email protected]>
@ckerr ckerr merged commit 18e729a into main Jan 19, 2024
9 checks passed
@ckerr ckerr deleted the optionally-delete-old-xcodes branch January 19, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Keep Previous Xcodes Indefinitely
5 participants