-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow deleting old Xcode versions #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
commented
Jan 18, 2024
@@ -4,7 +4,6 @@ const childProcess = require('child_process'); | |||
const fs = require('fs'); | |||
const program = require('commander'); | |||
const path = require('path'); | |||
const os = require('os'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused
jkleinsc
approved these changes
Jan 18, 2024
codebytere
force-pushed
the
optionally-delete-old-xcodes
branch
2 times, most recently
from
January 18, 2024 15:34
48f4437
to
62fcd66
Compare
codebytere
force-pushed
the
optionally-delete-old-xcodes
branch
from
January 18, 2024 17:24
62fcd66
to
0952051
Compare
dsanders11
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just one change to enforce valid values for the config option.
dsanders11
reviewed
Jan 18, 2024
Co-authored-by: Samuel Attard <[email protected]>
Co-authored-by: David Sanders <[email protected]>
Co-authored-by: David Sanders <[email protected]>
dsanders11
approved these changes
Jan 18, 2024
MarshallOfSound
approved these changes
Jan 18, 2024
ckerr
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539.
Adds a new config preference to optionally delete unused Xcode versions to save disk space.