Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up UIA types and remove unused prop #29255

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Fix up UIA types and remove unused prop #29255

merged 3 commits into from
Feb 17, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 13, 2025 •
edited
Loading

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Feb 13, 2025
@t3chguy t3chguy marked this pull request as ready for review February 13, 2025 09:52
@t3chguy t3chguy requested review from a team as code owners February 13, 2025 09:52
@t3chguy t3chguy requested review from richvdh and dbkr February 13, 2025 09:52
@t3chguy t3chguy self-assigned this Feb 13, 2025
@richvdh
Copy link
Member

richvdh commented Feb 13, 2025

Is this related to matrix-org/matrix-js-sdk#4702?

@t3chguy
Copy link
Member Author

t3chguy commented Feb 13, 2025

Yes, updated description

@t3chguy t3chguy mentioned this pull request Feb 13, 2025
Merged
richvdh
richvdh approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would have appreciated it if the showContinue changes were a separate commit, for easier review.

@t3chguy t3chguy added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@t3chguy t3chguy added this pull request to the merge queue Feb 17, 2025
Merged via the queue into develop with commit dd2da5c Feb 17, 2025
31 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/j4702 branch February 17, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh