Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out duplicated CSS for buttons in encryption settings #29269

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Factor out duplicated CSS for buttons in encryption settings #29269

merged 7 commits into from
Feb 18, 2025

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 14, 2025 •
edited
Loading

By adding a component to hold the common CSS

Split out from #29113

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@dbkr
Factor out duplicated CSS for buttons in encryption settings
5d4d154 
By adding a component to hold the common CSS
@dbkr dbkr added the T-Task Tasks for the team like planning label Feb 14, 2025
@dbkr dbkr marked this pull request as ready for review February 14, 2025 17:55
@dbkr dbkr requested review from a team as code owners February 14, 2025 17:55
@dbkr dbkr requested review from richvdh and t3chguy February 14, 2025 17:55
@dbkr dbkr requested a review from richvdh February 17, 2025 13:49
richvdh
richvdh approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dbkr dbkr added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit b7fea97 Feb 18, 2025
33 checks passed
@dbkr dbkr deleted the dbkr/encryption_card_buttons branch February 18, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @richvdh