Move CSS for ResetIdentityPanel into EncryptionCard #29311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to be re-used in other components. It's a *bit* magic that EncryptionCard applies style to divs within it, although it somewhat makes sense that it wants them styled a particular way. The alternative would be to add another component for a div child of encryption card like EncryptionCardButtons that just makes it flexbox and centered: I'm not sure which is better.
Because we only want it in the destructive cards, not the other ones.
florianduros
approved these changes
Feb 19, 2025
| * (mostly as somewhere for the common CSS to live). | ||
| */ | ||
| export function EncryptionCardEmphasisedContent({ children }: PropsWithChildren): JSX.Element { | ||
| return <div className="mx_EncryptionCard_emphasisedContent">{children}</div>; |
There was a problem hiding this comment.
You can use our Flex component instead (discovered recently)
As center affected the list items too. Also add it to the flex component because it didn't have it as an option.
andybalaam
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows it to be re-used in other components. This feels like a slightly silly component but it's the only option I can think of that isn't just duplicating the CSS.
Checklist
public/exportedsymbols have accurate TSDoc documentation.