Skip to content

Commit

Permalink
Explain why not using spec=MatrixFederationHttpClient
Browse files Browse the repository at this point in the history
  • Loading branch information
MadLittleMods committed Jan 24, 2025
1 parent dc547d6 commit e9ee86a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tests/federation/test_federation_out_of_band_membership.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ def default_config(self) -> JsonDict:

def make_homeserver(self, reactor: MemoryReactor, clock: Clock) -> HomeServer:
self.federation_http_client = Mock(
# spec=MatrixFederationHttpClient
# The problem with using `spec=MatrixFederationHttpClient` here is that it
# requires everything to be mocked which is a lot of work that I don't want
# to do when the code only uses a few methods (`get_json` and `put_json`).
)
return self.setup_test_homeserver(
federation_http_client=self.federation_http_client
Expand Down

0 comments on commit e9ee86a

Please sign in to comment.