Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link #734

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix dead link #734

merged 2 commits into from
Oct 14, 2024

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Oct 14, 2024

No description provided.

@stsdc stsdc merged commit 12e254c into elementary:master Oct 14, 2024
2 checks passed
@salim-b salim-b deleted the patch-1 branch October 14, 2024 14:21
@ryonakano
Copy link
Member

Maybe the target branch should have been main, not master?

@salim-b salim-b mentioned this pull request Oct 14, 2024
@salim-b
Copy link
Contributor Author

salim-b commented Oct 14, 2024

Maybe the target branch should have been main, not master?

Geez, sorry. I just clicked on the link prefixed with Home on this page: https://valadoc.org/granite/index.htm

So that one was outdated, too (I submitted vala-lang/valadoc-org#421 to fix that).

And I resubmitted this PR as #735.

Nevertheless, I'd like to ask: Why is there still a master branch when the default one was changed to be main? Wouldn't it make sense to delete master? (I'm in no way involved in Vala, so personally I don't care.)

@danirabbit
Copy link
Member

This actually makes sense to fix here too. There's both Granite 6 for GTK3 and Granite 7 for GTK4

danirabbit pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants