Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BOLFI parallelisation #481

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

uremes
Copy link
Contributor

@uremes uremes commented May 27, 2024

Summary:

copy kernel from gpy regression model gp_params to avoid the pickle issue reported here and allow BOLFI parallelisation also when a non-default kernel is used. fixes #263

How to test:

the pickle error is observed when we sample from a target_model that has a kernel in gp_params and either ipyparallel or multiprocessing client is used. for example the example code provided in #263 results in an error with the current ELFI version but works with the updated version.

Please make sure

  • You have read contribution guidelines
  • You have updated CHANGELOG.rst
  • You have listed the copyright holder for the work you are submitting (see next section)

If your contribution adds, removes or somehow changes the functional behavior of the package, please check that

  • You have included or updated all the relevant documentation, including docstrings
  • You have added appropriate functional and unit tests to ensure the new features behave as expected
  • You have run make lint, make docs and make test

and the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@hpesonen hpesonen merged commit 68a7418 into elfi-dev:dev May 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running a model using BOLFI with parallelization
2 participants