Do not disable buffer until all queued actions dispatched #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @elgerlambert any thoughts on this one? Could we get it merged and published? |
|
@elgerlambert ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters
bufferActions.jsto not disable the buffer until all actions in the queue are dispatched.The issue I had was that whilst the buffer was being purged, the dispatched actions in the queue were causing other actions to be dispatched by other parts of the code (like in
componentDidMount). Sincebuffer = falsehad already been set, these actions passed through thebufferActionsmiddleware and got dispatched and reduced before the buffer had finished emptying - causing them to be incorrectly ordered.resolves #67