-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to comply with scikitlearn >1.3 #44
Conversation
use available_if instead of removed if_delegate_has_method
Upgrade according to scikit-learn/scikit-learn#20506
fix to intended usage
Should fix #42 |
Hey @Richie94 Thanks for the PR with the changes! Could you please remove the modified reqs file from this PR? We are updating the library as we speak and we are managing the new dependencies elsewhere. See #45 @lopuhin this PR will probably not pass the tests, because we have dependencies on older versions of sklearn where we use the boston dataset. I suggest we keep it on hold while we fix the tests. |
it has been introduces in sklearn 1.0.0, so it wont run with old versions... im not mainly a python def, so im not sure on how you want to achieve compatibility with old versions. |
Thanks @Richie94 and @solegalli , and sorry @solegalli I missed the message, appreciate a reminder |
awesome thank you! |
With scikit learn 1.3 if_delegate_has_method has been removed in favor if if_available.
See scikit-learn/scikit-learn#20506
Therefore i updated the scikit learn version to above 1.3, and changed the calls to the ones i think should be used now.