Ignored empty strings, removed useless includes, added useful ones, t…

…ypo and conventions update

examples/example.cpp

@@ -2,7 +2,7 @@
 #include <iostream>
 
 int main() {
-    for (auto const &ns : blns::Blns::getStrings())
+    for (const auto& ns : blns::Blns::getStrings())
     {
         std::cout << ns << std::endl;
     }

include/blns/blns.h

@@ -4,10 +4,9 @@
 *
 * @author Elia Bieri <[email protected]>
 */
-#include <fstream>
-#include <iterator>
+
 #include <vector>
-#include <filesystem>
+#include <string>
 
 namespace blns
 {
@@ -18,12 +17,12 @@ class Blns
 
     /*
      * Returns the list of Naughty Strings
-     * @return list of naugthy strings
+     * @return list of naughty strings
      */
-    [[nodiscard]] static std::vector<std::string> const &getStrings() ;
+    [[nodiscard]] static const std::vector<std::string>& getStrings() ;
 
 private:
-    inline static std::vector<std::string> blns;
+    inline static std::vector<std::string> s_blns;
 
     static void readFile();
 };

src/blns/blns.cpp

@@ -1,13 +1,15 @@
 #include <blns/blns.h>
 #include <cassert>
-#include <algorithm>
 #include <string>
+#include <fstream>
+#include <vector>
+#include <filesystem>
 
-std::vector<std::string> const &blns::Blns::getStrings() {
-    if(blns.empty()) {
+const std::vector<std::string>& blns::Blns::getStrings() {
+    if(s_blns.empty()) {
         readFile();
     }
-    return blns;
+    return s_blns;
 }
 
 void blns::Blns::readFile() {
@@ -21,9 +23,9 @@ void blns::Blns::readFile() {
     std::string line;
     while(getline(blnsFile, line)) {
         // Skip comments in txt file
-        if(line.rfind('#', 0) != 0) {
-            blns.push_back(line);
+        if(!line.empty() && line.rfind('#', 0) != 0) {
+            s_blns.push_back(line);
         }
     }
-    assert(!blns.empty());
+    assert(!s_blns.empty());
 }