Merge pull request #275 from eliashaeussler/fix/log-uri-object

eliashaeussler · Aug 11, 2023 · 37cd59a · 37cd59a
2 parents 14be3ac + 022dcfb
commit 37cd59a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Http/Message/Handler/LogHandler.php b/src/Http/Message/Handler/LogHandler.php
@@ -52,7 +52,7 @@ public function onSuccess(Message\ResponseInterface $response, Message\UriInterf
             $this->logger->info(
                 'URL {url} was successfully crawled (status code: {status_code}).',
                 [
-                    'url' => (string) $uri,
+                    'url' => $uri,
                     'status_code' => $response->getStatusCode(),
                 ],
             );
@@ -65,7 +65,7 @@ public function onFailure(Throwable $exception, Message\UriInterface $uri): void
             $this->logger->error(
                 'Error while crawling URL {url} (exception: {exception}).',
                 [
-                    'url' => (string) $uri,
+                    'url' => $uri,
                     'exception' => $exception->getMessage(),
                 ],
             );

diff --git a/tests/src/Http/Message/Handler/LogHandlerTest.php b/tests/src/Http/Message/Handler/LogHandlerTest.php
@@ -66,7 +66,7 @@ public function onSuccessLogsSuccessfulCrawl(): void
             [
                 'message' => 'URL {url} was successfully crawled (status code: {status_code}).',
                 'context' => [
-                    'url' => 'https://www.example.com',
+                    'url' => new Psr7\Uri('https://www.example.com'),
                     'status_code' => 200,
                 ],
             ],
@@ -79,7 +79,7 @@ public function onSuccessLogsSuccessfulCrawl(): void
             new Psr7\Uri('https://www.example.com'),
         );
 
-        self::assertSame($expected, $this->logger->log[Log\LogLevel::INFO]);
+        self::assertEquals($expected, $this->logger->log[Log\LogLevel::INFO]);
     }
 
     #[Framework\Attributes\Test]
@@ -102,7 +102,7 @@ public function onFailureLogsFailedCrawl(): void
             [
                 'message' => 'Error while crawling URL {url} (exception: {exception}).',
                 'context' => [
-                    'url' => 'https://www.example.com',
+                    'url' => new Psr7\Uri('https://www.example.com'),
                     'exception' => 'oops, something went wrong.',
                 ],
             ],
@@ -113,6 +113,6 @@ public function onFailureLogsFailedCrawl(): void
             new Psr7\Uri('https://www.example.com'),
         );
 
-        self::assertSame($expected, $this->logger->log[Log\LogLevel::ERROR]);
+        self::assertEquals($expected, $this->logger->log[Log\LogLevel::ERROR]);
     }
 }