Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No crash on note with zero length name #592

Merged
merged 2 commits into from
Jan 14, 2025
Merged

No crash on note with zero length name #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50e98a
No crash on note with zero length name
sevaa Jan 13, 2025
0f5bf86
Comment placement
sevaa Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions elftools/elf/notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@ def iter_notes(elffile, offset, size):
note['n_offset'] = offset
offset += nhdr_size
elffile.stream.seek(offset)
# n_namesz is 4-byte aligned.
disk_namesz = roundup(note['n_namesz'], 2)
note['n_name'] = bytes2str(
CString('').parse(elffile.stream.read(disk_namesz)))
offset += disk_namesz
if note['n_namesz']:
# n_namesz is 4-byte aligned.
disk_namesz = roundup(note['n_namesz'], 2)
note['n_name'] = bytes2str(
CString('').parse(elffile.stream.read(disk_namesz)))
offset += disk_namesz
else:
note['n_name'] = None

desc_data = elffile.stream.read(note['n_descsz'])
note['n_descdata'] = desc_data
Expand Down
Loading