#21 Explain how to exit full screen #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sladomic Can this pull request be merged now? |
|
@jogrimst shouldn't we first revert to the code before this pull request #20 and then we can merge this one? |
jo-elimu
changed the title
jo-elimu
requested changes
May 19, 2017
There was a problem hiding this comment.
@gscdev In the ExitFullScreenActivity, when I press the screen (normal press), the hand animation disappears. Even if I never completed a swipe from outside the screen. Perhaps the hand animation should continue repeatedly until the child has managed to perform the gesture properly? Is there a way to detect if the status bar and navigation bar became visible?
jo-elimu
reviewed
Jun 18, 2017
| // @Override | ||
| // public void onCompletion() { | ||
| // TODO: 04/05/2017 audios en/sw Slide down from outside the screen | ||
| MediaPlayerHelper.playWithDelay(this, R.raw.slide_down_from_outside_the_screen, new MediaPlayerHelper.MediaPlayerListener() { |
There was a problem hiding this comment.
@gscdev I'm preparing these audios now.
jo-elimu
approved these changes
Jun 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.