Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: javax.servlet --> jakarta.servlet #1960

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jo-elimu
Copy link
Member

@jo-elimu jo-elimu commented Jan 15, 2025

Warning

Cannot be merged until we find a fix for the Spring Security problem.

Issue Number

Purpose

  • Change to Jakarta EE Namespace so that we can upgrade to Jetty 11 (Servlet 5, JSP 3.0), Spring 6, Spring Security 6, Hibernate 6.

Technical Details

  • These changes only work partially:
    • Spring Security causes redirect to /sign-on, and the page is not displayed.
    • 8 failing unit tests when running mvn clean test due to NoClassDefFound jakarta/servlet/ServletConnection

Testing Instructions

  • mvn jetty:run
  • mvn clean test

Screenshots


Format Checks

Note

Files in PRs are automatically checked for format violations with mvn spotless:check.

If this PR contains files with format violations, run mvn spotless:apply to fix them.

@jo-elimu jo-elimu self-assigned this Jan 15, 2025
@jo-elimu jo-elimu linked an issue Jan 15, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to Jakarta EE Namespace
1 participant