Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTP upload #60

Merged
merged 10 commits into from
Nov 6, 2024
Merged

Add FTP upload #60

merged 10 commits into from
Nov 6, 2024

Conversation

apriltuesday
Copy link
Collaborator

@apriltuesday apriltuesday commented Nov 6, 2024

Tasks

  • General-purpose FTP upload class
  • ENADataUploader
  • Integrate with CLI
  • Unit tests

@bedroesb bedroesb linked an issue Nov 6, 2024 that may be closed by this pull request
@apriltuesday apriltuesday marked this pull request as ready for review November 6, 2024 15:56
Copy link
Collaborator

@kdp-cloud kdp-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Could you also add the submission end-points in here:

config["webin"] = {
"development-url": "https://wwwdev.ebi.ac.uk/ena/dev/submit/webin/auth",
"development-token-url": "https://wwwdev.ebi.ac.uk/ena/dev/submit/webin/auth/token",
"production-url": "https://www.ebi.ac.uk/ena/submit/webin/auth",
"production-token-url": "https://www.ebi.ac.uk/ena/submit/webin/auth/token",
}
config["ena"] = {
"development-url": "https://wwwdev.ebi.ac.uk/ena/submit/webin-v2/",
"development-submission-url": "https://wwwdev.ebi.ac.uk/ena/submit/drop-box/submit/?auth=ENA",
"production-url": "https://www.ebi.ac.uk/ena/submit/webin-v2/",
"production-submission-url": "https://www.ebi.ac.uk/ena/submit/drop-box/submit/?auth=ENA",
}
config["biosamples"] = {
"development-url": "https://wwwdev.ebi.ac.uk/biosamples/samples/",
"development-submission-url": "https://wwwdev.ebi.ac.uk/biosamples/samples/",
"production-url": "https://www.ebi.ac.uk/biosamples/samples/",
"production-submission-url": "https://www.ebi.ac.uk/biosamples/samples/",
}

This is the part that generates the config file at install.

@apriltuesday
Copy link
Collaborator Author

@kdp-cloud I think it's there already, unless you mean something else?

Copy link
Collaborator

@kdp-cloud kdp-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! My mistake!

@kdp-cloud kdp-cloud merged commit 8d7dcde into elixir-europe:main Nov 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data submission to ENA
3 participants