Remove singleton VocIndex GenServer to make pure library #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the C algorithm code management out of a singleton GenServer since it maintains per-sensor state. This also makes this package a pure library and simplifies state handling in the port.
mnishiguchi
force-pushed
the
simplify-start_link
branch
from
4ab6928 to
a0a7bc6
Compare
mnishiguchi
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off #9 and creates one VocIndex GenServer per sensor. This enables more than one sensor to be attached and removes some complexity in restarting the C code when state needs to be re-initialized.